PACKED and __attribure__((packed)) aren't defined in SUN CC

[jerryyu]

PACKED and attribure((packed)) aren't defined in SUN CC, so they doesn't work in SUN C compiler. For the patch, at first if it's SUN CC will be checked. If it's Sun CC, both PACKED and attribute((packed)) will be defined to null.

[zany]

After each struct we need to end the packing by appending #pragma pack()

This needs to be reviewed on win32

[zany]

The symbol _WIN32 flags the platform not the compiler, which would be gcc anyway? If every other compiler recognises #pragma pack, this should be the portable way

#ifdef __GNUC__
#define PACKED __attribute__ ((packed))
#else
#define PACKED
#endif

#pragma pack(1)
struct {...} PACKED ;
#pragma pack()

[hsattler]

Yes, using the GNUC will save us a lot. MSVC also only supports pragma. However, why using that at all? According to http://gcc.gnu.org/onlinedocs/gcc/Pragmas.html gcc also supports the pragma statements.

Note that it would be better to use #pragma pack(push,1) and #pragma pack(pop)

[zany]

Nice. I can confirm that #pragma pack works on GCC 4.1 as well as GCC 3.4. Using push and pop would be nice and clean, it's a problem with certain gcc targets though. E.g. sparc-sun-solaris2.9/3.4.6 target does not support push and pop.

[zany]

Revised pragma pack patch

[zany]

Revised patch. Needs review.